CI: optimize ext4 mount options that can be toggled at runtime. #148085
+38
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-CI
This comment has been minimized.
This comment has been minimized.
the8472
force-pushed
the
ci-ext4-tweaks
branch
2 times, most recently
from
7c16001 to
026314e
Compare
mati865
reviewed
Oct 26, 2025
|
|
||
| if isLinux && [[ $(findmnt -n /) =~ "ext4" ]] ; then | ||
| # noauto_da_alloc since auto_da_alloc causes sync IO for some common file creation patterns | ||
| # lazytime avoids sync IO when (rel)atime updates are applied |
There was a problem hiding this comment.
Is it possible to use noatime here?
There was a problem hiding this comment.
Deleting stuff doesn't just update atime but also ctime and mtime, so I don't think noatime would make a difference here.
Anyway, the settings don't seem to make much of a difference, so this might not be due to sync-write-latency but due to read latency (enumerating the directories) or just being IOPS-starved (anemic cloud hardware).
I'll try running iostat alongside the deletion.
the8472
force-pushed
the
ci-ext4-tweaks
branch
from
026314e to
837210f
Compare
Looks like this actually limited by read latency. |
the8472
force-pushed
the
ci-ext4-tweaks
branch
6 times, most recently
from
fc302e1 to
549db0c
Compare
This comment has been minimized.
This comment has been minimized.
the8472
force-pushed
the
ci-ext4-tweaks
branch
2 times, most recently
from
14c1db1 to
78306cb
Compare
the8472
force-pushed
the
ci-ext4-tweaks
branch
from
78306cb to
964c658
Compare
|
Parallel deletion seems to help a bit, but not enough, trying something else in #148146 |
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #82099. The "free up disk space" step is taking 10m, that's a bit much.